Add the AVX10 target features #139675
Open
Add the AVX10 target features #139675
+48
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Urgau
reviewed
Apr 11, 2025
| "avx512vl", | ||
| "avx512vnni", | ||
| "avx512vpopcntdq", | ||
| "gfni", // This is a deviation from LLVM, but it is more consistent with the Intel specification |
There was a problem hiding this comment.
Is this known by LLVM folks? Is there an llvm issue?
There was a problem hiding this comment.
I have opened llvm/llvm-project#135394, I will file an issue in GCC bugtracker too. Also cc @rust-lang/wg-llvm ig
There was a problem hiding this comment.
Ok this is an issue on LLVM side, and a PR has been sent to fix this. So should we add these target features now, or when the LLVM fix lands? Imo it is not a problem if we add it now, it will just stop implying vaes and vpclmulqdq after the fix
There was a problem hiding this comment.
The LLVM fix was merged and is scheduled to be backported to LLVM20
CryZe
reviewed
Apr 12, 2025
|
r? compiler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent #138843
Adds the
avx10_target_featurefeature gate, andavx10.1andavx10.2target features.It is confirmed that Intel is dropping AVX10/256 (see this comment), so this should be safe to implement now.
The LLVM fix for llvm/llvm-project#135394 was merged, and has been backported to LLVM20, we just need a llvm patch in rustc for it to be completely resolved
@rustbot label O-x86_64 O-x86_32 A-target-feature A-SIMD